tree: 36a2732707bf9d5b7cef83c83ac7936d0ddf13f2 [path history] [tgz]
  1. flags/
  2. gr-auth/
  3. gr-event-interface/
  4. gr-reporting/
  5. services/
  6. app-context-init.ts
  7. app-context-init_test.js
  8. app-context.ts
  9. README.md
polygerrit-ui/app/services/README.md

What is services folder

‘services’ folder contains services used across multiple components.

What should be considered as services in Gerrit UI

Services should be stateful, if its just pure functions, consider having them in ‘utils’ instead.

Regarding all stateful should be considered as services or not, it‘s still TBD. Will update as soon as it’s finalized.

How to access service

We use AppContext to access instance of service. It helps in mocking service in tests as well. We prefer setting instance of service in constructor and then accessing it from variable. We also allow access straight from appContext especially in static methods.

import {appContext} from '../../../services/app-context.js';

class T {
  constructor() {
    super();
    this.flagsService = appContext.flagsService;
  }

  action1() {
    if (this.flagsService.isEnabled('test)) {
      // do something
    }
  }
}

staticMethod() {
  if (appContext.flagsService.isEnabled('test)) {
    // do something
  }
}

What services we have

Flags

‘flags’ is a service to provide easy access to all enabled experiments.

import {appContext} from '../../../services/app-context.js';

// check if an experiment is enabled or not
if (appContext.flagsService.isEnabled('test')) {
  // do something
}