Google Git
Sign in
gerrit / gerrit / 9da317cf62ec79397017683735f64759a42a0833
commit9da317cf62ec79397017683735f64759a42a0833[log] [tgz]
authorNitzan Gur-Furman <nitzan@google.com>Fri Oct 07 11:19:53 2022 +0200
committerEdwin Kempin <ekempin@google.com>Fri Nov 11 10:23:11 2022 +0100
tree57bd537dbcf658435f815322cb5ae59c685b275e
parent005be88f11c69e79539335093c4027fce2114a7f [diff]
Disallow suppressing emails on submit if there is a post approval diff

If a change is submitted and a post approval diff (called
stickyApprovalDiff in the codebase) is present, we now always use
Notify=ALL, no matter which notify setting the caller specified.

This fixes a security issue where a malicious user could submit code
changes without anyone ever seeing them if sticky approvals are
configured:
1. upload a new patch set to an already approved change, with
   suppressing email notifications
2. change is still submittable since the approvals are sticky
3. submit the change, again with suppressing email notifications

With this change suppressing email notifications for 3. is no longer
possible, so the approvers get an email with the post approval diff and
they can take action if it looks unexpected.

Change-Id: I3dbb2529a061b6be1947e60a3e0164badb1f57e2
Release-Notes: Suppressing emails on submit is disallowed now if there is a post approval diff
3 files changed
tree: 57bd537dbcf658435f815322cb5ae59c685b275e
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. web-dev-server.config.mjs
  41. WORKSPACE
  42. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update && apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.