| commit | 9d6a453d405f543f19408bef6c4376034cbc5b97 | [log] [tgz] |
|---|---|---|
| author | David Ostrovsky <david@ostrovsky.org> | Mon Jun 09 22:15:21 2014 +0200 |
| committer | Dave Borowitz <dborowitz@google.com> | Mon Jun 16 14:06:03 2014 +0000 |
| tree | d94ee42f0e424182448c9cecba158a5dc057bfc4 | |
| parent | 0369183e9206ffab04048fb6abed0dfc14e87776 [diff] |
Buck: Fix plugin build by not merging manifests from dependent JARs After posting this mail to mailing list [1], filing this issue [2], and creating this pull request [3], Buck team provided a solution to the problem: when multiple JARs contain MANIFEST files, the default behaviour of java_binary() was to merge the content of those manifest files together. That breaks our plugins, as the content from other JARs interfere with the manifest content of plugins. Recent Buck version [4] provides undocumented parameter to change this behaviour. [1] https://groups.google.com/forum/#!topic/buck-build/M7Nu71okdYY [2] https://github.com/facebook/buck/issues/86 [3] https://github.com/facebook/buck/pull/87 [4] https://github.com/facebook/buck/commit/\ 96ba1967ef941558bc4c12ce88d5eaeba0b23275 Change-Id: Ia228fb51cfe8db678c2551b9cd1802bdaf4d44fc