|author||Dave Borowitz <email@example.com>||Mon Mar 18 09:02:44 2019 -0700|
|committer||Dave Borowitz <firstname.lastname@example.org>||Mon Mar 18 09:02:44 2019 -0700|
Bind ChangeAttributeFactory as a DynamicSet DynamicMaps allow a view of plugin-provided bindings keyed by export names. The main use case for an export name is to provide something with that name that is visible to an end user, such as a new SSH command. In the case of ChangeAttributeFactory, the export name is entirely unused; it's just an arbitrary string that the plugin author provides, which has to be unique to their plugin, but is otherwise meaningless. By using DynamicSet instead of DynamicMap for these bindings, we eliminate one line of boilerplate for plugin authors, and avoid confusing them with the impression that this arbitrary string has meaning. The good news is that old plugins that use an explicit, arbitrary export name will continue to work, because DynamicSet is implemented internally by using separate binding annotations per instance. If callers use the DynamicSet interface, they get a unique annotation for free, but it still works if they explicitly pass the export annotation. Convert most tests in PluginFieldsIT to demonstrate the new way, but leave one test that uses the old explicit export to ensure that it still works. Change-Id: Iaf7e6ac8a53be115f1bc01e716e0fb3c04033754
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.