commit | 9d0ab2f4ec311c7e618bf553e108f9cd2f9cf316 | [log] [tgz] |
---|---|---|
author | Dave Borowitz <dborowitz@google.com> | Thu Dec 13 14:20:59 2018 -0800 |
committer | Dave Borowitz <dborowitz@google.com> | Fri Dec 14 10:18:34 2018 -0800 |
tree | 0eeb3dd9db50167f74381cff1f04032648f6c6fd | |
parent | 250a065b8080f2beb7ac002c3bc87b15f511f45f [diff] |
Fix NoteDb small tests to not depend on PrimaryStorage The shouldExist argument to ChangeNotes allows loading a ChangeNotes for a change that is yet to be created. It was incorrect for the updates created by TestChanges#newUpdate to always set shouldExist=true; the reality is that some tests require shouldExist=false, when creating the first update for a new change. It was an accident that this worked at all, since it was depending on the codepath where PrimaryStorage=REVIEW_DB, which was for writing incomplete change metadata to NoteDb during a migration. This migration code needs to go away, so we can no longer rely on this accident. Tweak the factory methods in AbstractChangeNotesTest to explicitly specify that some updates are for new changes. Change-Id: Ib6d30014814990ff5481a6bdf355c4ad63f66b85
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.