Log when appropriate if email delivery is skipped The outgoing mail codepath skips delivery in three different cases: * The message body is empty. This should never happen, so warn. * The message has no recipients. This can happen if all intended recipients have been filtered out by the EmailSender, for example because none of them has a reasonable preferred email address. Log to the info log in this case. * The message has no recipients except for the sender. This is perfectly normal, so don't log it. Change-Id: Iccefd67940e482888d55e65e75eb9c17135ee993
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java b/gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java index 997bc03..ce50002 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/mail/OutgoingEmail.java
@@ -268,7 +268,7 @@ protected boolean shouldSendMessage() { if (body.length() == 0) { // If we have no message body, don't send. - // + log.warn("Skipping delivery of email with no body"); return false; } @@ -276,7 +276,7 @@ // If we have nobody to send this message to, then all of our // selection filters previously for this type of message were // unable to match a destination. Don't bother sending it. - // + log.info("Skipping delivery of email with no recipients"); return false; }