Support SO_TIMEOUT configuration in Smtp email sender Socket SO_TIMEOUT is an important core config in socket communication allowing to adjust the socket read timeout value. In Java, when SO_TIMEOUT is set to a non-zero value, the read() call associated with the socket stream will block until it times out after the configured timeout by throwing a java.net.SocketTimeoutException. Otherwise, if SO_TIMEOUT is set 0, which is the default, it will never timeout. Sometimes this default may cause issues. In Gerrit, by default, the 'SendEmailExecutor' is a ScheduledThreadPoolExecutor with corePoolSize=1. Hence when sending emails concurrently, they will be sent one by one in FIFO order. If sending an email hangs and can't make progress, other sending tasks will be blocked until the hanging email is eventually sent or until memory is full (the DelayedWorkQueue used by ScheduledThreadPoolExecutor is an unbounded queue). Bug: Issue 40013496 Release-Notes: Support SO_TIMEOUT configuration in Smtp email sender Change-Id: I4adf69298f34b15c0a56a18cf269abd374597104 Signed-off-by: Dyrone Teng <dyroneteng@gmail.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.