| commit | 9bc65ff9262ebe1fc51d18bd98c3772a703ae4f2 | [log] [tgz] |
|---|---|---|
| author | Kamil Musin <kamilm@google.com> | Tue Feb 20 17:15:11 2024 +0100 |
| committer | Kamil Musin <kamilm@google.com> | Wed Feb 28 10:28:48 2024 +0100 |
| tree | 32db2492c5595300c12808a9ee95d8680d641ab9 | |
| parent | 229eddee7bd57f1ff6048e3cb53d422e5c7583eb [diff] |
Clarify that setChangeTopic/Hashtag can be undefined The methods internally call GrRestApiHelper.send(). The behaviour of this method is following - on Network error throw error - on Server error report error (via 'server-error' event), but return successfully. It will attempt parsing the payload in getResponseObject, but since it's a "Server error" it will return "null" The trackPromises in gr-change-list-topic-flow and gr-change-list-hashtag-flow expect that the promise rejects if the promise failed, which is not the case (it can return null). Update the methods with correct return type annotation, additionally pass in throwingErrorCallback, to make the behaviour inline with the expectation of trackPromises Additionally remove duplicate tests around error handling. For both topic and hashtag flow the exact same test as the one deleted is present earlier in the file. Google-Bug-Id: b/297849592 Release-Notes: skip Change-Id: I608f1db9b9a67456be4296a82a7d59dddf91643f
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.