| commit | f64ef68bcda5ac39f53ccc2a5140a231d9963c14 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Feb 04 16:53:24 2016 +0100 |
| committer | Edwin Kempin <ekempin@google.com> | Fri Feb 05 12:51:04 2016 +0100 |
| tree | 54c297789405c65260d97c04dd8e66a5130e45e9 | |
| parent | 4b2384b5827fb9d1b315077f2a3ef3db668e3fcc [diff] |
ChangeControl.GenericFactory#validateFor: Don't load change from db All callers of ChangeControl.GenericFactory#validateFor(Change.Id, CurrentUser) cannot provide the project name, which we would need to load the change through ChangeNotes.Factory. Hence we need to lookup the change from the index. Since we request no fields when looking up the change from the index, rereading it is enforced, hence the change we get back is not stale. Move the methods to find changes from ChangeUtil into a separate class. This is needed because ChangeUtil with all its dependencies cannot be injected into ChangeControl.GenericFactory, but all those dependencies are not needed for looking up changes from the index. Change-Id: I9c2ee58486046f3a2ae80b588613b708a66d8306 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.