commit 9b47b783112e861741e290afeb227ca3cce0f020
author Dave Borowitz <dborowitz@google.com> Wed Apr 20 18:42:27 2016 -0400
committer Dave Borowitz <dborowitz@google.com> Thu Apr 21 14:37:43 2016 -0400
tree 8faee065d9a81206b3311f9c9bb5d21547aed474
parent 01f8e903a5c08ffab3f81bcd3aadbac0213028ca

RebuildNoteDb: Actually throw when NoteDb writes are disabled

The die method returns an exception, which we were never throwing.
Proceeding with writes disabled has the effect in NoteDbUpdateManager
of short-circuiting and not doing any work.

Change-Id: Ib0c3d5c7a40d6b4ab2205e690e6d5d32feb9fac0

gerrit-pgm/src/main/java/com/google/gerrit/pgm/RebuildNoteDb.java

diff --git a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/RebuildNoteDb.java b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/RebuildNoteDb.java
index ae4a429..ed05786 100644
--- a/gerrit-pgm/src/main/java/com/google/gerrit/pgm/RebuildNoteDb.java
+++ b/gerrit-pgm/src/main/java/com/google/gerrit/pgm/RebuildNoteDb.java
@@ -120,7 +120,7 @@
     sysInjector = createSysInjector();
     sysInjector.injectMembers(this);
     if (!notesMigration.enabled()) {
-      die("NoteDb is not enabled.");
+      throw die("NoteDb is not enabled.");
     }
     LifecycleManager sysManager = new LifecycleManager();
     sysManager.add(sysInjector);