Google Git
Sign in
gerrit / gerrit / 9b3e021378e5980f589f73fda2ca9b080bd45ca3
commit9b3e021378e5980f589f73fda2ca9b080bd45ca3[log] [tgz]
authorYoussef Elghareeb <ghareeb@google.com>Fri Jan 21 14:40:18 2022 +0100
committerYoussef Elghareeb <ghareeb@google.com>Fri Jan 21 14:44:33 2022 +0100
tree40687fd6cac394654de724aba5d08a4e58dfc1a3
parent0ac56543274a190c978c44015ac7b02c3a365b34 [diff]
Add label votes to ChangeInfo if "DETAILED_LABELS" is not requested

Previously if "DETAILED_LABELS" is requested, we returned the "all"
attribute which contains a list of approvals. Each approval contains a
vote value for the label along with other attributes of the account who
made the vote (id, email, permitted voting range, etc...). We don't
serve the ApprovalInfo list deliberately if DETAILED_LABELS is not
requested because the computation of the permitted voting range is
expensive and slows down the dashboard if done on many changes. Hence,
the "all" attribute in LabelInfo was only served if the DETAILED_LABELS
option is requested, but not with the LABELS option.

In this change, we update LabelsJson if the LABELS options is requested
such that all attributes are returned, except the permitted_voting_range
attribute in LabelInfo#all.

This change is needed so that we show the label votes on the dashboard.
The computation is cheap since we already store approvals in the change
index (field "_approvals") and use it to populate ChangeData for changes
retrieved from the index.

Change-Id: I83b7a200d012a02cf340e6eb032c6989e5db11b6
3 files changed
tree: 40687fd6cac394654de724aba5d08a4e58dfc1a3
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. polymer-bridges
  20. .bazelignore
  21. .bazelproject
  22. .bazelrc
  23. .bazelversion
  24. .editorconfig
  25. .git-blame-ignore-revs
  26. .gitignore
  27. .gitmodules
  28. .gitreview
  29. .mailmap
  30. .pydevproject
  31. .zuul.yaml
  32. BUILD
  33. COPYING
  34. INSTALL
  35. Jenkinsfile
  36. package.json
  37. README.md
  38. SUBMITTING_PATCHES
  39. version.bzl
  40. WORKSPACE
  41. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.