| commit | 84eed99d92de52595f02392b48c7275d14acbc65 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Wed Apr 12 12:11:58 2017 -0400 |
| committer | Dave Borowitz <dborowitz@google.com> | Wed Apr 12 12:21:28 2017 -0400 |
| tree | 089e58469e7679ea0ff13db27999a9da12ec2618 | |
| parent | 1f26b86cf4eaa3333a9280c41b72e4a3a8e663ff [diff] |
Remove query test for different timestamp resolutions We used to sort results based on the sortkey field in Change, which was a combination of minute-resolution timestamp and change number. Thus it made sense to have separate tests for timestamp resolutions above and below 1 minute. However, sortkey was killed long ago, with the last vestiges removed in 2015 (I87660f8e0), so it no longer serves a purpose to have these separate methods. One specific issue with these methods was the assertion in the sub-minute resolution case that the updated timestamps of each change differ by less than one minute. This assertion assumes that only Gerrit is responsible for ticking the test clock, so we know there is some bound on the number of ticks that happen in the test. But this is not a safe assumption: TestTimeUtil mucks with global Joda state, and it's possible that library code used in a secondary index implementation also ticks the same clock. Thus there is no way to guarantee that this assertion will pass. Fortunately, for the reasons described above, this assertion wasn't really serving any purpose, and it goes away in the reworked tests. Change-Id: I7412b066ae6c98bcec788fba8c534c4a45f50a6f
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.