commit 98f448cd3e971b534adf17c723e7f00a35381211
author Shawn Pearce <sop@google.com> Mon Jun 20 16:44:55 2016 -0700
committer Shawn Pearce <sop@google.com> Tue Jun 21 11:45:08 2016 -0700
tree 691e278fc782b57c04ea113e9928fcc19375e3d2
parent ffe9a9f0cd56b3e21de1e24bb903c3257caec5a6

Optimize edit handling in VisibleRefFilter

Checking each ref through the RefNames.isRefsEditOf is still several
percent of the total garbage created by a busy Gerrit server filtering
references for clients... most of which don't have pending edits.

Rewrite this handling to reduce the StringBuilder allocations so that
the user prefix is built once and reused over the refs.

Fix the TODO about filtering edits to visible changes; we have the
Set<Change.Id> readily available and can parse the Change.Id out of
the edit ref name to test in the set once we know the ref is owned by
the current user.

Rework much of the VisibleRefFilter logic to simplify the
!showMetadata case to short-circuit through the loop more quickly.
This speeds up advertisment generation for pushes by a very small
amount, but also simplifies every single branch so its worth the code
churn either way.

Change-Id: I15d97ec7783e8bd6c7a042a020cdcf4352273cab