| commit | 98cd9ea59b2f8f93d229976184b556d19c3a6585 | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Tue Apr 04 11:32:22 2017 -0400 |
| committer | Dave Borowitz <dborowitz@google.com> | Tue Apr 11 11:08:41 2017 -0400 |
| tree | fbbaf2fd8fbfa0dd8f240eb47a9a9c9e10d00d24 | |
| parent | 28dd2ae37cf7a0629c6197be731d37ec0169e408 [diff] |
StalenessChecker: Change is stale if primary storage doesn't match After running PrimaryStorageMigrator on a change, the note_db_state field changes, but the change is not automatically reindexed. The idea was that the change should be detected as stale--after all, its row_version and note_db_state changed. Unfortunately, the implementation of StalenessChecker doesn't actually flag a change as stale in this case, because it ignores row_version entirely when the change is NoteDb primary. Worse, the now-stale value in the index still doesn't include the change meta ref in the ref_state field, since that ref isn't recorded when ReviewDb is primary, so we aren't able to check for staleness using the NoteDb state either. Break this stalemate by considering a change as stale if its PrimaryStorage in the index differs between the version of the Change located in primary storage and the version in the index. Change-Id: I3c5d9981bf6e8a465509d94cac13c66e8368bdbe
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.