| commit | 971df9ffd489c60e72721297371b3b498bb38607 | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Fri May 08 16:37:23 2020 +0200 |
| committer | Dhruv Srivastava <dhruvsri@google.com> | Thu Aug 13 14:03:31 2020 +0200 |
| tree | 48b3b833bf9b9b40c0089c2cb305dd783665797a | |
| parent | 866d783f5aebcd38f2188c954842b4abdbe44b84 [diff] |
Remove <gr-fixed-panel> in favor of position:sticky <gr-fixed-panel> was a super complex attempt at doing what position:sticky does out of the box. Presumably <gr-fixed-panel> was added before all modern browers had decent support of position:sticky. The desire to remove this was triggered by observing buggy positioning in diff view: "File" is half obscured when you load Gerrit with a diff page directly. And this bug could be traced down to <gr-fixed-panel> not updating the height in the right moment. Stickiness of the main header did currently not work anyway, and IMO is also not desirable. So we only have stickiness of the file header on the two file pages (diff-view and editor-view). The one thing that position:sticky cannot do is to change its appearance based on whether it is currently floating or not. So we cannot retain the old behavior of showing the box-shadow only in floating mode. But arguably the box-shadow is actually also nice to have in normal mode. This was previously attempted in change 143855, but we believe that with top:0 everything is just working fine. Screenshots: https://imgur.com/a/PaE4epn Change-Id: I421941c12023deea9f7d7f9886810ff0e9a7f7e7
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.