Google Git
Sign in
gerrit / gerrit / 948089a15c4a6c3bef087d0956847d7ca215dd81
commit948089a15c4a6c3bef087d0956847d7ca215dd81[log] [tgz]
authorDave Borowitz <dborowitz@google.com>Thu Sep 03 10:33:42 2015 -0400
committerDave Borowitz <dborowitz@google.com>Thu Sep 03 11:10:26 2015 -0400
treeb21f8c9c4db7139b222c281c58ecfa86f81e953a
parent3b2aa8aace54d1f3a8e626e87f7ff5b878d203ad [diff]
GerritPublicKeyChecker: Fix possible null dereference

PGPPublicKey#getSignaturesForID(String) may return null if the user ID
is not present in the key. This shouldn't happen since we're iterating
over present IDs, but it's easy enough to detect and use the empty
iterator instead.

Coverity-CID: 107364
Change-Id: Ic321ea77650bbe2f1698d2a576a44b6e72bc9299
1 file changed
tree: b21f8c9c4db7139b222c281c58ecfa86f81e953a
  1. .settings/
  2. bucklets/
  3. contrib/
  4. Documentation/
  5. gerrit-acceptance-tests/
  6. gerrit-antlr/
  7. gerrit-cache-h2/
  8. gerrit-common/
  9. gerrit-extension-api/
  10. gerrit-gpg/
  11. gerrit-gwtdebug/
  12. gerrit-gwtexpui/
  13. gerrit-gwtui/
  14. gerrit-gwtui-common/
  15. gerrit-httpd/
  16. gerrit-launcher/
  17. gerrit-lucene/
  18. gerrit-main/
  19. gerrit-oauth/
  20. gerrit-openid/
  21. gerrit-patch-commonsnet/
  22. gerrit-patch-jgit/
  23. gerrit-pgm/
  24. gerrit-plugin-api/
  25. gerrit-plugin-archetype/
  26. gerrit-plugin-gwt-archetype/
  27. gerrit-plugin-gwtui/
  28. gerrit-plugin-js-archetype/
  29. gerrit-prettify/
  30. gerrit-reviewdb/
  31. gerrit-server/
  32. gerrit-sshd/
  33. gerrit-util-cli/
  34. gerrit-util-http/
  35. gerrit-util-ssl/
  36. gerrit-war/
  37. lib/
  38. plugins/
  39. ReleaseNotes/
  40. tools/
  41. website/
  42. .buckconfig
  43. .buckversion
  44. .editorconfig
  45. .gitignore
  46. .gitmodules
  47. .mailmap
  48. .pydevproject
  49. .watchmanconfig
  50. BUCK
  51. COPYING
  52. INSTALL
  53. README.md
  54. SUBMITTING_PATCHES
  55. VERSION
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Buck and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && buck build all

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.

Events

  • November 7-8 2015: Gerrit User Conference, Mountain View. (Register).
  • November 9-13 2015: Gerrit Hackathon, Mountain View. (Invitation Only).
  • March 2016: Gerrit Hackathon, Berlin. (Details to be confirmed).