commit | 699516107aa05467c9811fb8b4bdadb5fca5f278 | [log] [tgz] |
---|---|---|
author | Dhruv Srivastava <dhruvsri@google.com> | Mon Dec 07 21:37:03 2020 +0100 |
committer | Dhruv Srivastava <dhruvsri@google.com> | Fri Jan 08 12:19:31 2021 +0100 |
tree | 8dd2ea09fe1090692803ded4bbff3584fb725aa2 | |
parent | b4c32b2b5ca7a981446ac0db18c31c6462755f36 [diff] |
Update thread in file view if user updates it in other places Currently user can interact with the comment threads in the change view through: 1. reply dialog 2. change log 3. comments tab 4. individually expanded diff in file list When user creates or updates a draft in views 1,2 or 3 they send an event to change-view(comment-refresh) which requests new drafts and updates the ChangeComments object. The comment threads in diffs are however not updated if they were already expanded. This leads to inconsistent state where the thread is updated in one view but not in another view. This inconsistency also leads to other inconsistent states such as creating two different drafts on the same thread in two different views. (https://imgur.com/a/ul1X23P) gr-file-list already has the method reloadCommentsForThreadWithRootId which updates a thread with given rootId if it's updated in other places. gr-file-list does not render the gr-thread-list element, therefore changing the comment thread in file view itself does not fire the thread-list-modified event and cause re-rendering of the thread. Change-Id: I77f5fea9083f75a11aa3ffc1530e3e061d74aa75
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.