Google Git
Sign in
gerrit / gerrit / 935c7550e348bb94bac2b5073d17304f9d90ab7b
commit935c7550e348bb94bac2b5073d17304f9d90ab7b[log] [tgz]
authorBecky Siegel <beckysiegel@google.com>Thu Dec 21 12:48:59 2017 -0800
committerBecky Siegel <beckysiegel@google.com>Thu Dec 21 14:43:14 2017 -0800
tree0da98663ee30f5d4a5dc5a8828b7961f58265b25
parentc4d42c43c82a26b0e2d3e6de46afc80a7a4b184a [diff]
Fix code that caused changes to break in MS Edge

There was an exception due to calling Object.keys on an undefined value
that caused a promise to fail to resolve.

This resulted in 'loading' not getting set to false, and the change was
never visible.

Compounded with this error is the fact that gr-error-manager did not
pick up on this exception, because unhandledrejection does not work in
Edge (or firefox), which is used in gr-reporting to catch errors.

Bug: Issue 7896
Change-Id: I12a99e3acc1dc1e3592a0d5995f937eccafa4c1c
1 file changed
tree: 0da98663ee30f5d4a5dc5a8828b7961f58265b25
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. gerrit-gwtdebug/
  6. gerrit-gwtui/
  7. gerrit-gwtui-common/
  8. gerrit-plugin-gwtui/
  9. java/
  10. javatests/
  11. lib/
  12. plugins/
  13. polygerrit-ui/
  14. prolog/
  15. prologtests/
  16. resources/
  17. tools/
  18. webapp/
  19. website/
  20. .bazelproject
  21. .editorconfig
  22. .git-blame-ignore-revs
  23. .gitignore
  24. .gitmodules
  25. .mailmap
  26. .pydevproject
  27. BUILD
  28. COPYING
  29. INSTALL
  30. README.md
  31. SUBMITTING_PATCHES
  32. version.bzl
  33. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.