commit 9324e9af125d4fb7df402e22945ae4e917dac0d4
author David Pursehouse <david.pursehouse@sonymobile.com> Mon Dec 16 14:15:20 2013 +0900
committer David Pursehouse <david.pursehouse@sonymobile.com> Mon Jun 30 18:00:29 2014 +0900
tree ba133215465e83c2fc7e2314e928c7ba774c5091
parent d8090dc8a4d88c497b30320b913135296f6e6662

Prevent possible NPE in AuthorRevision.equals

Add check for the given object being an instance of the
expected class.

This clears a warning from Findbugs.

Change-Id: I097f8894239f04804a0038b504eccd8e2374b07a

gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java

diff --git a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java
index e167927..c487bf6 100644
--- a/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java
+++ b/gerrit-gwtui/src/main/java/com/google/gerrit/client/change/History.java
@@ -222,6 +222,9 @@
 
     @Override
     public boolean equals(Object o) {
+      if (!(o instanceof AuthorRevision)) {
+        return false;
+      }
       AuthorRevision b = (AuthorRevision) o;
       return author == b.author && revision == b.revision;
     }