Merge "Audit: sandbox integration tests for removing flakiness"
diff --git a/javatests/com/google/gerrit/acceptance/git/RefAdvertisementIT.java b/javatests/com/google/gerrit/acceptance/git/RefAdvertisementIT.java
index 4d45794..1a0f256 100644
--- a/javatests/com/google/gerrit/acceptance/git/RefAdvertisementIT.java
+++ b/javatests/com/google/gerrit/acceptance/git/RefAdvertisementIT.java
@@ -259,16 +259,13 @@
public void uploadPackSubsetOfBranchesVisibleWithEdit() throws Exception {
allow("refs/heads/master", Permission.READ, REGISTERED_USERS);
- Change c = notesFactory.createChecked(project, cd3.getId()).getChange();
- String changeId = c.getKey().get();
-
// Admin's edit is not visible.
setApiUser(admin);
- gApi.changes().id(changeId).edit().create();
+ gApi.changes().id(cd3.getId().get()).edit().create();
// User's edit is visible.
setApiUser(user);
- gApi.changes().id(changeId).edit().create();
+ gApi.changes().id(cd3.getId().get()).edit().create();
assertUploadPackRefs(
"HEAD",
@@ -287,21 +284,16 @@
allow("refs/heads/master", Permission.READ, REGISTERED_USERS);
allow("refs/*", Permission.VIEW_PRIVATE_CHANGES, REGISTERED_USERS);
- Change change3 = notesFactory.createChecked(project, cd3.getId()).getChange();
- String changeId3 = change3.getKey().get();
- Change change4 = notesFactory.createChecked(project, cd4.getId()).getChange();
- String changeId4 = change4.getKey().get();
-
// Admin's edit on change3 is visible.
setApiUser(admin);
- gApi.changes().id(changeId3).edit().create();
+ gApi.changes().id(cd3.getId().get()).edit().create();
// Admin's edit on change4 is not visible since user cannot see the change.
- gApi.changes().id(changeId4).edit().create();
+ gApi.changes().id(cd4.getId().get()).edit().create();
// User's edit is visible.
setApiUser(user);
- gApi.changes().id(changeId3).edit().create();
+ gApi.changes().id(cd3.getId().get()).edit().create();
assertUploadPackRefs(
"HEAD",
@@ -322,9 +314,8 @@
deny("refs/heads/master", Permission.READ, REGISTERED_USERS);
allow("refs/heads/branch", Permission.READ, REGISTERED_USERS);
- String changeId = cd3.change().getKey().get();
setApiUser(admin);
- gApi.changes().id(changeId).edit().create();
+ gApi.changes().id(cd3.getId().get()).edit().create();
setApiUser(user);
assertUploadPackRefs(
@@ -410,7 +401,7 @@
ReceiveCommitsAdvertiseRefsHook.Result r = getReceivePackRefs();
assertThat(r.allRefs().keySet())
.containsExactly(
- // meta refs are excluded even when NoteDb is enabled.
+ // meta refs are excluded
"HEAD",
"refs/heads/branch",
"refs/heads/master",
diff --git a/plugins/BUILD b/plugins/BUILD
index 30a30dd..bddff41 100644
--- a/plugins/BUILD
+++ b/plugins/BUILD
@@ -33,6 +33,7 @@
"//java/com/google/gerrit/extensions:api",
"//java/com/google/gerrit/git",
"//java/com/google/gerrit/index",
+ "//java/com/google/gerrit/index/project",
"//java/com/google/gerrit/index:query_exception",
"//java/com/google/gerrit/json",
"//java/com/google/gerrit/lifecycle",
diff --git a/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-js-api-interface_test.html b/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-js-api-interface_test.html
index 78fba83..e0c7c37 100644
--- a/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-js-api-interface_test.html
+++ b/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-js-api-interface_test.html
@@ -441,11 +441,11 @@
test('installing preloaded plugin', () => {
let plugin;
- window.ASSETS_PATH = 'http://blips.com/chitz';
+ window.ASSETS_PATH = 'http://blips.com/chitz/';
Gerrit.install(p => { plugin = p; }, '0.1', 'preloaded:foo');
assert.strictEqual(plugin.getPluginName(), 'foo');
assert.strictEqual(plugin.url('/some/thing.html'),
- 'http://blips.com/chitz/plugins/foo/some/thing.html');
+ 'http://blips.com/plugins/foo/some/thing.html');
delete window.ASSETS_PATH;
});
diff --git a/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-public-js-api.js b/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-public-js-api.js
index 8bf4a2d..36a428d 100644
--- a/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-public-js-api.js
+++ b/polygerrit-ui/app/elements/shared/gr-js-api-interface/gr-public-js-api.js
@@ -217,14 +217,9 @@
};
Plugin.prototype.url = function(opt_path) {
- const relPath = '/plugins/' + this._name + (opt_path || '/');
- if (window.location.origin === this._url.origin) {
- // Plugin loaded from the same origin as gr-app, getBaseUrl in effect.
- return this._url.origin + Gerrit.BaseUrlBehavior.getBaseUrl() + relPath;
- } else {
- // Plugin loaded from assets bundle, expect assets placed along with it.
- return this._url.href.split('/plugins/' + this._name)[0] + relPath;
- }
+ const base = Gerrit.BaseUrlBehavior.getBaseUrl();
+ return this._url.origin + base + '/plugins/' +
+ this._name + (opt_path || '/');
};
Plugin.prototype.screenUrl = function(opt_screenName) {
