Google Git
Sign in
gerrit / gerrit / 90bed3f2432b243a3f19c3570c05feac38e954b9
commit90bed3f2432b243a3f19c3570c05feac38e954b9[log] [tgz]
authorDavid Pursehouse <dpursehouse@digital.ai>Tue Jun 09 22:07:19 2020 +0200
committerDavid Ostrovsky <david@ostrovsky.org>Tue Jun 09 22:37:06 2020 +0200
tree73cb815d64fae098c3470b3693c74ffacf2a093b
parent6589e0877ec51fff9324caefa981739d7f25af11 [diff]
DatabasePubKeyAuth: Exclude comment from peer key line if present

In I9a934bda3 base64 decoding was changed from using commons-codec
library to Guava library. However, this broke users who specify not only
base 64 encoded key, but also provide comment, similar to authorized
keys format without leading algorithm.

Clarify the documentation what format is supported in peer keys file and
skip the comment part if provided.

Also add integration test for peer keys authentication with three use
cases:

1. Test format: <key_material comment>
2. Test format: <key_material>
3. No peer keys file present

Test Plan:

  $ bazel test javatests/com/google/gerrit/integration/ssh:peer-keys-auth

Bug: Issue 12884
Change-Id: Id748cb55497e3347477012911f716ac5b7b69863
4 files changed
tree: 73cb815d64fae098c3470b3693c74ffacf2a093b
  1. .settings/
  2. antlr3/
  3. contrib/
  4. Documentation/
  5. e2e-tests/
  6. java/
  7. javatests/
  8. lib/
  9. modules/
  10. plugins/
  11. polygerrit-ui/
  12. prolog/
  13. prologtests/
  14. proto/
  15. resources/
  16. tools/
  17. webapp/
  18. polymer-bridges
  19. .bazelignore
  20. .bazelproject
  21. .bazelrc
  22. .bazelversion
  23. .editorconfig
  24. .git-blame-ignore-revs
  25. .gitignore
  26. .gitmodules
  27. .gitreview
  28. .mailmap
  29. .pydevproject
  30. .zuul.yaml
  31. BUILD
  32. COPYING
  33. INSTALL
  34. Jenkinsfile
  35. package.json
  36. README.md
  37. SUBMITTING_PATCHES
  38. version.bzl
  39. WORKSPACE
  40. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.