commit 90a2ffb1b5d483927ed58ba59f5f4cab660455b4
author Sam Saccone <samccone@google.com> Thu May 02 16:02:03 2019 -0700
committer Sam Saccon°͌͌͌͌͌͌͌͌͌͌͌͌͌͌͌͌͌͌͌͌͌͌͌͌͌e 🐐 <samccone@google.com> Fri May 03 13:39:05 2019 +0000
tree 65a379d49c073542e0bc07266319c678e52e8a22
parent 0347a820102adefd3b22b226d443368c0ade8e8f

When an error is encountered during submit trigger app error state

The current behavior when an error is hit is to silently fail with no
UI feedback resulting in user confusion around why nothing happened.

Change-Id: I266b3ad271419c3638f99d31a052d70fabde4555

polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js

diff --git a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js
index 8ca9128..84c8cee 100644
--- a/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js
+++ b/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js
@@ -756,6 +756,11 @@
       return this.send(this._includeComments, this.canBeStarted)
           .then(keepReviewers => {
             this._purgeReviewersPendingRemove(false, keepReviewers);
+          }).catch(err => {
+            this.dispatchEvent(new CustomEvent('show-error', {
+              bubbles: true,
+              detail: {message: `Error submitting review ${err}`},
+            }));
           });
     },