commit 903a7174988cd4412b7692a74de98afeeaf05c39
author Dhruv Srivastava <dhruvsri@google.com> Mon Dec 21 16:32:43 2020 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Mon Dec 21 16:32:43 2020 +0000
tree 84d0ded67d3d09fd4b04461eb3090250058cdf11
parent b26297d10ec601a289794daa45eda790ec6b9170
parent 922d2c3781d7de2c45259bf419f3291a17743b38

Merge "Document behaviour of sorting threads for edit & Parent patchset"

polygerrit-ui/app/elements/change/gr-thread-list/gr-thread-list.ts

diff --git a/polygerrit-ui/app/elements/change/gr-thread-list/gr-thread-list.ts b/polygerrit-ui/app/elements/change/gr-thread-list/gr-thread-list.ts
index e236652..ff30452 100644
--- a/polygerrit-ui/app/elements/change/gr-thread-list/gr-thread-list.ts
+++ b/polygerrit-ui/app/elements/change/gr-thread-list/gr-thread-list.ts
@@ -159,7 +159,9 @@
     if (c1.thread.patchNum !== c2.thread.patchNum) {
       if (!c1.thread.patchNum) return 1;
       if (!c2.thread.patchNum) return -1;
-      // TODO(TS): Explicit comparison for 'edit' and 'PARENT' missing?
+      // Threads left on Base when comparing Base vs X have patchNum = X
+      // and CommentSide = PARENT
+      // Threads left on 'edit' have patchNum set as latestPatchNum
       return c1.thread.patchNum > c2.thread.patchNum ? -1 : 1;
     }