Google Git
Sign in
gerrit / gerrit / 8f9e11957a1c1ba3fd39e7a5d58196d0d9972116
commit8f9e11957a1c1ba3fd39e7a5d58196d0d9972116[log] [tgz]
authorDave Borowitz <dborowitz@google.com>Tue Apr 04 11:43:36 2017 -0400
committerDave Borowitz <dborowitz@google.com>Tue Apr 11 11:08:41 2017 -0400
tree60924f857259e9a0ede4bbdfe64b320424ef9f11
parent98cd9ea59b2f8f93d229976184b556d19c3a6585 [diff]
Never autoRebuild when ReviewDb is disabled for changes

Changes can't be rebuilt when their primary storage is NoteDb.
Generally, when ReviewDb is disabled for changes, we assume that it is
not possible to encounter a change with PrimaryStorage == REVIEW_DB, so
it seemed like checking the PrimaryStorage when setting the autoRebuild
bit was sufficient.

However, in the corner case described in I3c5d9981, it is possible to
encounter a REVIEW_DB change via deserializing a stale Change proto from
the index, even though the actual primary storage of every change is
NOTE_DB. Trying to auto-rebuild in this case will result in an error,
as ChangeRebuilder rereads the change from primary storage and will
refuse to rebuild a NoteDb-primary change.

Ensure we never hit the auto-rebuilding path when ReviewDb is disabled
by explicitly checking the state of the NotesMigration, rather than
depending only on the PrimaryStorage.

Change-Id: Iae54fbe94f85e57dee6a2c9848b89e0697ff88e6
1 file changed
tree: 60924f857259e9a0ede4bbdfe64b320424ef9f11
  1. .settings/
  2. contrib/
  3. Documentation/
  4. gerrit-acceptance-framework/
  5. gerrit-acceptance-tests/
  6. gerrit-antlr/
  7. gerrit-cache-h2/
  8. gerrit-common/
  9. gerrit-elasticsearch/
  10. gerrit-extension-api/
  11. gerrit-gpg/
  12. gerrit-gwtdebug/
  13. gerrit-gwtexpui/
  14. gerrit-gwtui/
  15. gerrit-gwtui-common/
  16. gerrit-httpd/
  17. gerrit-launcher/
  18. gerrit-lucene/
  19. gerrit-main/
  20. gerrit-oauth/
  21. gerrit-openid/
  22. gerrit-patch-commonsnet/
  23. gerrit-patch-jgit/
  24. gerrit-pgm/
  25. gerrit-plugin-api/
  26. gerrit-plugin-gwtui/
  27. gerrit-prettify/
  28. gerrit-reviewdb/
  29. gerrit-server/
  30. gerrit-sshd/
  31. gerrit-test-util/
  32. gerrit-util-cli/
  33. gerrit-util-http/
  34. gerrit-util-ssl/
  35. gerrit-war/
  36. lib/
  37. plugins/
  38. polygerrit-ui/
  39. ReleaseNotes/
  40. tools/
  41. website/
  42. .bazelproject
  43. .editorconfig
  44. .git-blame-ignore-revs
  45. .gitignore
  46. .gitmodules
  47. .mailmap
  48. .pydevproject
  49. BUILD
  50. COPYING
  51. INSTALL
  52. README.md
  53. SUBMITTING_PATCHES
  54. version.bzl
  55. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.