8f258d99726b80f5b890602eb5379543144bca81 - gerrit

commit	8f258d99726b80f5b890602eb5379543144bca81	[log] [tgz]
author	Conley Owens <cco3@android.com>	Thu Jun 07 18:08:59 2012 -0700
committer	Conley Owens <cco3@android.com>	Tue Jun 12 08:43:47 2012 -0700
tree	3b9b7ed7450b47fb9accdf8f0c55ecb2ef2adb33
parent	4d26f3cd62f379ce995a597342847c8630cfc5a3 [diff]

No longer throw InvalidChangeOp in changeUpdated

InvalidChangeOperationExceptions are only thrown when we pass a null
change to this method.  It is better that we just don't pass the change
and add a more useful error to the ReviewResult.

We no longer perform a check to see if the patchset we have is the most
current one.  restore/abandon happens at the change level and the
patchset is just fetched to append a message to the change.

Change-Id: I3b3af1e3982fcd9111214a7c66a28476189c923b

gerrit-common/src/main/java/com/google/gerrit/common/data/ReviewResult.java[diff]
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/AbandonChangeHandler.java[diff]
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/RestoreChangeHandler.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/changedetail/AbandonChange.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/changedetail/RestoreChange.java[diff]
gerrit-sshd/src/main/java/com/google/gerrit/sshd/commands/ReviewCommand.java[diff]

7 files changed