| commit | 8d82e4c3cac7360e1474394dd76df00fb99b7a96 | [log] [tgz] |
|---|---|---|
| author | Ben Rohlfs <brohlfs@google.com> | Fri Jun 24 09:25:42 2022 +0200 |
| committer | Ben Rohlfs <brohlfs@google.com> | Mon Jun 27 14:24:52 2022 +0200 |
| tree | f651172c61fd6c8ff06e55ad30893d61cb6bb6a3 | |
| parent | 036d7cf9616e0215a7449a72c4247d392c145ffb [diff] |
Fix arrow key scrolling by allowing shortcuts to not prevent default In dom-util we already have a `doNotPrevent` shortcut option. Add this option to shortcut-controller, as well. And add the corresponding `options` parameter optionally to a couple of signatures. Then fix the actual bug, which is that arrow keys should allow the user to scroll on the change page. The shortcuts bound by file-list were preventing that, because they trigger on arrow key strokes, and the default behavior of a keyboard shortcut is that `preventDefault()` is called. We are now setting the new option and deciding in the handler method whether preventing default is desired or not. This was tested using Dev Helper: Browser scrolling using arrow keys works on the change page when the file list is not "all expanded". Release-Notes: skip Google-Bug-Id: b/211878043 Change-Id: I61034ec7cdd13a303be3e4b30370be09ff6ab830
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.