| commit | 8cfe4de1f890fd3f903dd179061cea937c255c2c | [log] [tgz] |
|---|---|---|
| author | Kamil Musin <kamilm@google.com> | Tue Feb 06 15:03:26 2024 +0100 |
| committer | Kamil Musin <kamilm@google.com> | Tue Feb 27 10:57:09 2024 +0100 |
| tree | 4d5c624c644c6d423cd3b272929c3dd48c6ce295 | |
| parent | 0a09eb378a981ded8f4625fcad6606707e4df150 [diff] |
Update fetchRawJSON method - rename to the "fetch": method has no logic specific to JSON and only adds error handling. Original "fetch" is marked private, as there is no reason that its caller can't call fetchRawJSON instead. - remove cancel condition: this is not used in the codebase and it's semantics are suprising, as it is evaluated once the request is finished, but before the body is read. - convert to `async` method for better readability - add documentation for the input arguments - add await when calling errFn: While the usecase for which await errFn was added initially has to do with reading response, it's better for consistent semantics (and to be the same as send method) to do this for "Network error" as well, even though response is not available. - copy tests for `fetch` from the test file for the old fetcher. Google-Bug-Id: b/297849592 Release-Notes: skip Change-Id: I629739f6f3550e59b37432cde3a47d2fe38ee584
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.