| commit | 94c5d03ecce005789dfb8f5a9512d31660a41e3c | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Fri Sep 24 09:37:51 2021 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Fri Sep 24 13:26:37 2021 +0200 |
| tree | 3563c226dd6fdbba81c36d780d99258f8108aa44 | |
| parent | 706427457f405afbce61199fd57fae3afef20e2e [diff] |
PostReview: Send batch event when multiple reviewers are added at once So far when multiple reviewers are added at once via the PostReview REST endpoint we've sent out one event per each newly added reviewer. Now we only send out a single event with all newly added reviewers. This follows the example of the email notifications, where we also do not send out one email notification for each newly added reviewers, but only one batch email at the end. The event for removing reviewers does not allow to provided multiple removed reviewers, hence for reviewer removals we continue to send out one event for each removed reviewer. Adding CCs and adding/removing reviewers by email doesn't trigger any event, hence we do not need to do anything for those. Sending out one batch event instead of single events per reviewers provides more flexibility for the listeners of the event, as they can decide to do an operation per reviewer or a batch operation for all reviewers. An example of such a listener is the code-owners plugin that posts the paths that are owned by the reviewers as change message. So far it was forced to post one change message per reviewer, but now it can post a single change message that contains the owned paths for all newly added reviewers. This improve the latency of the PostReview REST endpoint because now we will do only a single NoteDb update instead of one NoteDb updater per reviewer. Speaking of the code-owners plugin this will also allow us to post the change message asynchronously and thus reduce the latency for PostReview calls (computing the owned paths is rather expensive and can contribute significantly to the latency of PostReview). Posting the change messages asynchronously when the event is received once per reviewer would not be working that well, as it would mean posting a change message for each new reviewer in parallel, which is prone to fail with LOCK_FAILURES. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I22b82d35d7c4becebdda6ae8b6bc3f67ec75bc96
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.