8a7bbc13a4f73b808b552877138d975889b44666 - gerrit

commit	8a7bbc13a4f73b808b552877138d975889b44666	[log] [tgz]
author	Shawn O. Pearce <sop@google.com>	Fri Apr 27 18:20:48 2012 -0700
committer	Shawn O. Pearce <sop@google.com>	Fri Apr 27 18:20:48 2012 -0700
tree	731564baa44eb179ab738295496f36925b20c1dc
parent	1eee2c9d8f352483781e772f35dc586a69ff5646 [diff]

Use Guice to feed dependencies to ApprovalsUtil

Classes shouldn't use static methods with long dependency lists. They
should use Guice injection to get their dependencies, especially if
they are very common ones like ReviewDb or ApprovalTypes.

ChangeUtil is a disaster so just paper over the one call site that is
harder to clean up.

Change-Id: Ia32fbf32175dcc84f8ae78361b128ce527ea99fa

gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/changedetail/RebaseChange.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/ApprovalsUtil.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/ChangeUtil.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/config/GerritRequestModule.java[diff]
gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java[diff]

5 files changed