| commit | 99219382d7df0a81c8d9e735965ec931a21ea4a7 | [log] [tgz] |
|---|---|---|
| author | Milutin Kristofic <milutin@google.com> | Wed Jun 17 09:50:47 2020 +0200 |
| committer | Milutin Kristofic <milutin@google.com> | Thu Jun 25 22:21:16 2020 +0200 |
| tree | 07b96a1499520bf28ccfa1e26233398d0f354e42 | |
| parent | 1808746abbbb14456223c0b9c36c8dd7ed5b6756 [diff] |
Fix diff-builder leaks When a user navigates in a diff page between files or expand/collapse diff on change page, diff components like gr-diff-builder and layers are not even detached. Layers via listeners are holding many old gr-diff-builders with many diff lines, which are never garbage collected. This change added a clear function on gr-diff-builders which removes listeners. After this gr-diff-builders are not leaked and are properly garbage collected. When browsed 10 files, before it leaked 2 MBs of gr-diff-builders and after this change it leaked 0 MBs of gr-diff-builders. This also fixes the issue with sometimes missing gr-coverage-layer. Since gr-coverage-layer was updating leaked gr-diff-builders and not a gr-diff-builder rendered on page. Change-Id: Ic247e0629b7b91ec3904d061517caed144a4216a
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.