| commit | 360a7c751e7ddf0470b2918e1c910898c63c7cd2 | [log] [tgz] |
|---|---|---|
| author | Fabio Ponciroli <ponch78@gmail.com> | Thu May 20 15:35:54 2021 +0200 |
| committer | Luca Milanesio <luca.milanesio@gmail.com> | Mon May 24 11:21:02 2021 +0100 |
| tree | 5973aed8a44bd2f47fb475f6cf04025b51f0d498 | |
| parent | 2abd14e762159b9580cac72c0d4a4b8f7eafa674 [diff] |
Always terminate the ServletRequest associated task The TaskThunk associated to the ServletRequest is visible in the ProjectQoSFilter scope only. If the whole ServletRequest is served by multiple request/response context and one of them dies unexpectedly before entering the ProjectQoSFilter, the TaskThunk is not properly terminated. The consequences of that, on the long run, is thread starvation and possibly Gerrit unresponsiveness. This is because: * TaskThunk is allocated on one executor of the SSH thread pools (interactive or batch) * The executor stays in TaskThunk::wait() *forever* and won't release the executor anymore, reducing the ability for Gerrit to serve requests * Longer term, all executors are hanged and Gerrit is technically dead * There is no solution other than restarting Gerrit Explicitly ending the TaskThunk in the ServletRequest callback. Bug: Issue 14495 Change-Id: Ie914bf4bf4b6167d8dd29d527a2bbed455fe3048
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.