| commit | 894b74566cb466995ede2f30cecc070b1512805b | [log] [tgz] |
|---|---|---|
| author | Dave Borowitz <dborowitz@google.com> | Mon Feb 06 16:30:44 2017 -0500 |
| committer | Edwin Kempin <ekempin@google.com> | Tue Feb 07 10:53:44 2017 +0100 |
| tree | 56df123c5b18060175426e98916712e98782b475 | |
| parent | fefce2217ca93efe4cd0c59650e523ab2723da5d [diff] |
RevisionIT: Fix test for post-submit approval after deletion There is a bug (or maybe just a questionable behavior) where PostReview doesn't update the postSubmit bit on a 0 vote in ReviewDb even if the vote was made after submission. This was causing a difference from NoteDb in this test, since NoteDb was recording this 0 vote as postSubmit. Rather than delve too deeply into PostReview at this time, just fix the test to handle the more common case of a nonzero label. Note that the new test assertion would have failed under ReviewDb (but not NoteDb) if we left the vote value at 0. Change-Id: I1c71ace23693a0c27bb60a0d6e8202a719e0477a
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.