| commit | 893c1b6db0fb10ff6bfd19b5b6bcb7f508c6d9fe | [log] [tgz] |
|---|---|---|
| author | Zhen Chen <czhen@google.com> | Thu Oct 13 15:21:01 2016 -0700 |
| committer | Zhen Chen <czhen@google.com> | Tue Oct 18 10:27:11 2016 -0700 |
| tree | f8c853f98ba4e897b1357aaa59a0dfc14cefc946 | |
| parent | 91fc61a883612e30ca2dd2471245817f400b29cf [diff] |
Fix project ordering bug in submodule subscription The initial idea for sorting project is relying on the sorted branches. However, sorted branches does not always guarantee a valid order for projects. For example: Scenario: super.master -> sub.master(C1) and super.dev -> sub.dev(C2) When change C1 and C2 are submitted together, there are multiple possible sorted branches orders, here are two example. 1. sub.master - super.master - sub.dev - super.dev 2. sub.master - sub.dev - super.master - super.dev Only #2 can derive a valid project order and #1 will give us a project circular subscription exception. Rewrite the project sorting algorithm: 1. find all *superbranches* (branches that have subscriptions) in a superproject 2. find all submodule projects for these superbranches Recursively doing 1,2 until there is no superbranches, and add that project to the sorted project list. Tests are also added for the example. Change-Id: Ia8e794f630ce303320c242fb9922d831f502c186
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.