commit | ae1a2251b2ef310cedaf7bacaadf96fff2d8a7fe | [log] [tgz] |
---|---|---|
author | Ben Rohlfs <brohlfs@google.com> | Thu Nov 17 11:30:56 2022 +0100 |
committer | Ben Rohlfs <brohlfs@google.com> | Thu Nov 17 11:30:56 2022 +0100 |
tree | 1808b246521228c05f26ead1ca4e3284a5a634a3 | |
parent | 23fc2a72064cdd442cee799726afc2490715d0a4 [diff] |
Fix the padding of draft comment textarea Since release 1124 the padding in draft comments has become too narrow: https://imgur.com/a/hOx8m8d The padding in `iron-autogrow-textarea` is based on a css mixin. Css mixins are legacy technology that we are trying to avoid by all means. They need polyfills and special care. We use them only when we must, which is for iron- and paper-components. You can only use a css mixin, if it used in a *Polymer* element somewhere. `gr-css-mixins` was introduced to take care of that. Maybe `--iron-autogrow-textarea` was overlooked when it was created? Anyway, adding it there solves the issue. The root cause for the regression was probably that the shared styles were referenced in `gr-overlay`, which was still a Polymer element. The issue appeared as soon as the last Polymer element referencing the shared styles was gone. Release-Notes: skip Change-Id: I0466417f12b2626778c2f7c278501f052c02c361
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.