Register a default kex handler with the SshDaemon

With MINA updated to 2.8.0 we can easily support the server-sig-algs key
exchange extension. This is necessary to support modern clients when
using RSA keys as they have begun to disable RSA+SHA1 support. RSA+SHA2
remains viable, but for clients to use that combo the server must
indicate support via the server-sig-algs key exchange extension.

Updating MINA to 2.8.0 was not sufficient for Gerrit because Gerrit does
not use MINA's ServerBuilder. The MINA 2.8.0 update only addresses this
issue automatically when using the ServerBuilder, as it sets the default
kexExtensionHandler for you. Since Gerrit is building the server itself
we need to set the kexExtensionHandler to MINA's default handler which
includes server-sig-algs support. This is the behavior you would get if
using MINA 2.8.0 and its ServerBuilder.

Making this update produces this log line in ssh client logs:

  debug1: kex_input_ext_info: server-sig-algs=<...rsa-sha2-512,rsa-sha2-256,ssh-rsa>

This log line does not appear with older Gerrit as the SSH server didn't
previously have a kex handler.

Release-Notes: Support ssh kex server-sig-algs for modern RSA clients
Bug: Issue 13930
Change-Id: Ia822d0ab291ce5a1cc29dfbe2ac9e2de499fafc3
(cherry picked from commit 0b7dba05dfc7d065acc15baee9ec192a99cce4cd)
1 file changed
tree: 30c08da090b69e297b57a5e764144ba96b03a87b
  1. .settings/
  2. .ts-out/
  3. antlr3/
  4. contrib/
  5. Documentation/
  6. e2e-tests/
  7. java/
  8. javatests/
  9. lib/
  10. modules/
  11. plugins/
  12. polygerrit-ui/
  13. prolog/
  14. prologtests/
  15. proto/
  16. resources/
  17. tools/
  18. webapp/
  19. .bazelignore
  20. .bazelproject
  21. .bazelrc
  22. .bazelversion
  23. .editorconfig
  24. .git-blame-ignore-revs
  25. .gitignore
  26. .gitmodules
  27. .gitreview
  28. .mailmap
  29. .pydevproject
  30. .zuul.yaml
  31. BUILD
  32. COPYING
  33. INSTALL
  34. Jenkinsfile
  35. package.json
  36. README.md
  37. SUBMITTING_PATCHES
  38. version.bzl
  39. WORKSPACE
  40. yarn.lock
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status Maven Central

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 8 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8

To run a Ubuntu 20.04 based Gerrit image:

    docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.