| commit | 8820b348a28cd52eea1b0f6c42807ced0bc37b62 | [log] [tgz] |
|---|---|---|
| author | Jonathan Nieder <jrn@google.com> | Fri Sep 13 15:32:31 2013 -0700 |
| committer | Jonathan Nieder <jrn@google.com> | Fri Sep 13 15:32:31 2013 -0700 |
| tree | 4891438338ec77c03a00a1d45b351026d9d585a4 | |
| parent | 569f8dca84dcfd469244a0983ba07d6ee381d814 [diff] |
Avoid unnecessary copy of query match list ResultSet.toList() is defined to return a mutable list belonging to the caller. Change-Id: I466346fa1196cc3b201743927412ca80e5fc5e80 Signed-off-by: Jonathan Nieder <jrn@google.com>
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/QueryProcessor.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/QueryProcessor.java index 0bf13b4..bdce7f4 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/QueryProcessor.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/QueryProcessor.java
@@ -261,7 +261,7 @@ List<List<ChangeData>> out = Lists.newArrayListWithCapacity(cnt); for (int i = 0; i < cnt; i++) { - List<ChangeData> results = Lists.newArrayList(matches.get(i).toList()); + List<ChangeData> results = matches.get(i).toList(); Collections.sort(results, sortkeyAfter != null ? cmpAfter : cmpBefore); if (results.size() > maxLimit) { moreResults = true;