commit 86d22c2276dc32bcfec2200c7dfeaa17c146fd8f
author Shawn O. Pearce <sop@google.com> Tue Jul 31 13:11:02 2012 -0700
committer Shawn O. Pearce <sop@google.com> Sat Aug 04 13:04:15 2012 -0700
tree 779fa2554eddb214b4cd077ea3426824830e6f97
parent 423c4a972c75fdb43f4cc87842f43cd8dad37654

Make portions of ListChanges public

This enables other callers to use ListChanges, for example a plugin
might want to drive ListChanges with their own arguments without going
through the args4j option parser.

Change-Id: I5cfd342673e9e381079b2c1891fe73e48be3e93b

gerrit-common/src/main/java/com/google/gerrit/common/changes/ListChangesOption.java

diff --git a/gerrit-common/src/main/java/com/google/gerrit/common/changes/ListChangesOption.java b/gerrit-common/src/main/java/com/google/gerrit/common/changes/ListChangesOption.java
index dbd36e8..a5ab851 100644
--- a/gerrit-common/src/main/java/com/google/gerrit/common/changes/ListChangesOption.java
+++ b/gerrit-common/src/main/java/com/google/gerrit/common/changes/ListChangesOption.java
@@ -38,6 +38,14 @@
     this.value = v;
   }
 
+  public int getValue() {
+    return value;
+  }
+
+  public static ListChangesOption fromValue(int value) {
+    return ListChangesOption.values()[value];
+  }
+
   public static EnumSet<ListChangesOption> fromBits(int v) {
     EnumSet<ListChangesOption> r = EnumSet.noneOf(ListChangesOption.class);
     for (ListChangesOption o : ListChangesOption.values()) {

gerrit-server/src/main/java/com/google/gerrit/server/query/change/ListChanges.java

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ListChanges.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ListChanges.java
index 4fc7665..a900175 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ListChanges.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ListChanges.java
@@ -124,12 +124,12 @@
   private List<String> queries;
 
   @Option(name = "--limit", aliases = {"-n"}, metaVar = "CNT", usage = "Maximum number of results to return")
-  void setLimit(int limit) {
+  public void setLimit(int limit) {
     imp.setLimit(limit);
   }
 
   @Option(name = "-o", multiValued = true, usage = "Output options per change")
-  void addOption(ListChangesOption o) {
+  public void addOption(ListChangesOption o) {
     options.add(o);
   }
 
@@ -139,7 +139,7 @@
   }
 
   @Option(name = "-P", metaVar = "SORTKEY", usage = "Previous changes before SORTKEY")
-  void setSortKeyAfter(String key) {
+  public void setSortKeyAfter(String key) {
     // Querying for the prior page of changes requires sortkey_after predicate.
     // Changes are shown most recent->least recent. The previous page of
     // results contains changes that were updated after the given key.
@@ -148,7 +148,7 @@
   }
 
   @Option(name = "-N", metaVar = "SORTKEY", usage = "Next changes after SORTKEY")
-  void setSortKeyBefore(String key) {
+  public void setSortKeyBefore(String key) {
     // Querying for the next page of changes requires sortkey_before predicate.
     // Changes are shown most recent->least recent. The next page contains
     // changes that were updated before the given key.
@@ -193,6 +193,14 @@
     return this;
   }
 
+  public ListChanges addQuery(String query) {
+    if (queries == null) {
+      queries = Lists.newArrayList();
+    }
+    queries.add(query);
+    return this;
+  }
+
   public void query(Writer out)
       throws OrmException, QueryParseException, IOException {
     if (imp.isDisabled()) {