commit 860fe4d024f00d0da6daefec7900c17a20ac9f39
author Milutin Kristofic <milutin@google.com> Mon Nov 23 16:13:45 2020 +0100
committer Milutin Kristofic <milutin@google.com> Mon Nov 23 16:29:13 2020 +0100
tree 13f583f2df9f3bd7aae39f1cf526c55c8d2b6447
parent 556f795b8def9829eaaa909e6a3045ea4c284e67

Refactor show-alert, page-error events

Change-Id: I38b55a8ceaa5819742e819cea0349fcecfb4b1ce

polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.ts

diff --git a/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.ts b/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.ts
index ac65297..fde7234 100644
--- a/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.ts
+++ b/polygerrit-ui/app/elements/admin/gr-repo-access/gr-repo-access.ts
@@ -52,7 +52,7 @@
   PropertyTreeNode,
   PrimitiveValue,
 } from './gr-repo-access-interfaces';
-import {EventType, fire} from '../../../utils/event-util';
+import {firePageError, fireAlert} from '../../../utils/event-util';
 
 const NOTHING_TO_SAVE = 'No changes to save.';
 
@@ -155,15 +155,7 @@
   }
 
   _reload(repo: RepoName) {
-    const errFn = (response?: Response | null) => {
-      this.dispatchEvent(
-        new CustomEvent('page-error', {
-          detail: {response},
-          composed: true,
-          bubbles: true,
-        })
-      );
-    };
+    const errFn = (response?: Response | null) => firePageError(this, response);
 
     this._editing = false;
 
@@ -517,7 +509,7 @@
       !Object.keys(addRemoveObj.remove).length &&
       !addRemoveObj.parent
     ) {
-      fire(this, EventType.SHOW_ALERT, NOTHING_TO_SAVE);
+      fireAlert(this, NOTHING_TO_SAVE);
       return;
     }
     const obj: ProjectAccessInput = ({