| commit | 850b1c312ce8c283b2bfd503d7a142f7ca599e84 | [log] [tgz] |
|---|---|---|
| author | Saša Živkov <sasa.zivkov@sap.com> | Mon Dec 09 17:24:27 2019 +0100 |
| committer | Saša Živkov <zivkov@gmail.com> | Mon Dec 09 21:13:14 2019 +0000 |
| tree | 2243fa75b1f5a1bd02ea080609a57a5713fa83cc | |
| parent | c5e879b8adfc019750b6ec0b16c0d5e6d90adcaa [diff] |
Fix handling of interactive/batch users in the QoS filter For the git-over-http requests this filter didn't work properly because the basic authentication happened later in the filter chain and at the moment when the ProjectQoSFilter was invoked the current user was not yet set. Therefore, the current user was always AnonymousUser in this filter and, by default, it always used the interactive queue type. The sshd.batchThreads [1] setting didn't work as documented i.e. to define the max number of Git requests for batch users over SSH and HTTP together. Bind ProjectQoSFilter after the ProjectBasicAuthFilter which is bound from the GitOverHttpModule so that the current user is authenticated when the ProjectQoSFilter is reached. [1] https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#sshd.batchThreads Change-Id: I0a5a70a5ee2d6416b69aa3ab4e4c55640bca8670
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.