commit | 8462ab7e56bec3a3cb0657f59b3273c6a581b732 | [log] [tgz] |
---|---|---|
author | Dave Borowitz <dborowitz@google.com> | Thu Apr 21 13:48:12 2016 -0400 |
committer | Dave Borowitz <dborowitz@google.com> | Fri Apr 22 10:56:17 2016 -0400 |
tree | d93016c805434ad0ef561e738ae9275206448893 | |
parent | 76a6f73a16bd478a0b2541461066e3dedb3bd7bb [diff] |
ChangeRebuilderImpl: Don't try to read old notes value When we're rebuilding a change, we don't care about what was previously in its notes, as it might have been corrupt, or had some other problem. However we do need to read the ChangeNotes in order to create a ChangeUpdate. We still want to use a single ChainedReceiveCommands mediated by the NoteDbUpdateManager, so that we can do a single atomic update from the old, bad notes SHA-1 to the new SHA-1. A way to achieve both these goals is to teach ChangeNotes to read its SHA-1 from the same ChainedReceiveCommands. Since one of the first things we do when rebuilding a change is to stage the delete of the ref, this will be as if the ChangeNotes is read from an empty ref, which is exactly what we want. Change-Id: I6c64068dc82be466041c69ed3ef55cd01def7dca
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.