commit 84229b5e61f91db3e9dc9e2c376d1a1b4b16c410
author Edwin Kempin <ekempin@google.com> Mon Jul 15 06:28:01 2024 +0000
committer Edwin Kempin <ekempin@google.com> Mon Jul 15 06:28:01 2024 +0000
tree 6cf0969921439ee49b482a3d3df996e12644ac29
parent cda696ab0b1e02cb6b9f9d88ff030039d62bc1a7

Record in reject count metric whether the push was done by a service user

The reject count metric counts rejection reasons for git pushes. This
change extends the push kind so that we can not only distinguish between
magic and direct pushes, but also between pushes by a human user and
pushes by a service user (ideally those would be different fields, but
metrics can have at most 3 fields). Knowing whether the git push was
done by a human user or service user is important if we want to conclude
if improving messages for common rejection reasons makes sense. E.g. if
pushes from human users are often rejected with a certain reason, we
might want to improve the error message to inform the user better what's
wrong and what they need to do. On the other hand improving error
messages for rejection reasons that are often hit by service users has
likely much less impact. Hence we would like to be able to distinguish
between pushes from human users and pushes from service users.

Bug: Google b/151127672
Release-Notes: skip
Change-Id: I4eb349fbb44b4b23319410ea823f14c55b90a31f
Signed-off-by: Edwin Kempin <ekempin@google.com>