Google Git
Sign in
gerrit / gerrit / 834458e26c0c7b601c1314490bc59e310dd367a0
commit834458e26c0c7b601c1314490bc59e310dd367a0[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Mon Sep 05 09:44:31 2016 +0200
committerEdwin Kempin <ekempin@google.com>Mon Sep 05 09:50:56 2016 +0200
tree0c7bfdc1d8a8413e29bbdc2f5547b8177167e9be
parenta7e0fce3eb8270d795b35f6fe3219ca21513840a [diff]
UrlModule: Add comment about missing binding for /plugins/ REST collection

UrlModule binds servlets for all REST root collections except for
'/plugins/'. Due to this plugins cannot add REST views on PLUGIN_KIND.
However this is intentional. '/plugins/' is already handled by
HttpPluginServlet which is bound in HttpPluginModule. Binding 2
different servlets on the same regex would result in undefined
behavior. If a plugin is serving anything under its '/plugins/<id>/'
namespace like a static file for JavaScript or a custom servlet or
protocol it may no longer work if UrlModule's binding is being used.

Add a comment to UrlModule so we are not tempted to add a binding for
a servlet that handles '/plugins/' here, as this would break the
plugins as described above.

Change-Id: I50a7883d5674c54d7637fd1ee2767b171c773e58
Signed-off-by: Edwin Kempin <ekempin@google.com>
1 file changed
tree: 0c7bfdc1d8a8413e29bbdc2f5547b8177167e9be
  1. .settings/
  2. bucklets/
  3. contrib/
  4. Documentation/
  5. gerrit-acceptance-framework/
  6. gerrit-acceptance-tests/
  7. gerrit-antlr/
  8. gerrit-cache-h2/
  9. gerrit-common/
  10. gerrit-extension-api/
  11. gerrit-gpg/
  12. gerrit-gwtdebug/
  13. gerrit-gwtexpui/
  14. gerrit-gwtui/
  15. gerrit-gwtui-common/
  16. gerrit-httpd/
  17. gerrit-launcher/
  18. gerrit-lucene/
  19. gerrit-main/
  20. gerrit-oauth/
  21. gerrit-openid/
  22. gerrit-patch-commonsnet/
  23. gerrit-patch-jgit/
  24. gerrit-pgm/
  25. gerrit-plugin-api/
  26. gerrit-plugin-archetype/
  27. gerrit-plugin-gwt-archetype/
  28. gerrit-plugin-gwtui/
  29. gerrit-plugin-js-archetype/
  30. gerrit-prettify/
  31. gerrit-reviewdb/
  32. gerrit-server/
  33. gerrit-sshd/
  34. gerrit-util-cli/
  35. gerrit-util-http/
  36. gerrit-util-ssl/
  37. gerrit-war/
  38. lib/
  39. plugins/
  40. polygerrit-ui/
  41. ReleaseNotes/
  42. tools/
  43. website/
  44. .bazelrc
  45. .buckconfig
  46. .buckversion
  47. .editorconfig
  48. .gitignore
  49. .gitmodules
  50. .mailmap
  51. .pydevproject
  52. .watchmanconfig
  53. BUCK
  54. COPYING
  55. INSTALL
  56. README.md
  57. SUBMITTING_PATCHES
  58. VERSION
  59. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Buck and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && buck build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.