commit | 8239d5c835da30bda499a2e2c833ebe9d1270752 | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Fri Dec 23 14:29:59 2022 +0100 |
committer | Edwin Kempin <ekempin@google.com> | Fri Dec 23 15:03:08 2022 +0100 |
tree | 0af16d7685b4113e2ea8cd5035030f949281010e | |
parent | 5df55b71bc6ebd19715e672d50b00f7aec6bf0fe [diff] |
Allow removing a non-visible account as a reviewer through PostReview If a visible change has a reviewer whose account is not visible, this account can be seen on the change (because the change is visible) but the reviewer cannot be removed through the PostReview REST endpoint (since the account is not visible). Checking the account visibility when removing a reviewer through the PostReview REST endpoint is unneeded, since the user already knows that this account exists (since they can see this account as a reviewer on the change). Hence just drop the account visibility check when reviewers are removed so that the reviewer removal can be successful. This is consistent with the behaviour of the DeleteReviewer REST endpoint that already allows to remove reviewers whose account is not visible. Being able to remove reviewers whose account is not visible is especially important if spam accounts add themselves as reviewers to changes. Bug: Google b/263303865 Release-Notes: Added support to remove a non-visible account as a reviewer through the PostReview REST endpoint Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I725ea878bf7298815847d0c25539b59f3a74edf5
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.