Google Git
Sign in
gerrit/gerrit/82071b883e00524a23cf2dca5436525c1bdb16be
commit
82071b883e00524a23cf2dca5436525c1bdb16be
[log]
author
Patrick Hiesel <hiesel@google.com>
Fri Sep 15 13:55:13 2017 +0200
committer
Patrick Hiesel <hiesel@google.com>
Wed Sep 20 10:10:45 2017 +0200
tree
c810e687f37c2827983b955f98b828da9273a21e
parent
43ca94d3823679d7e9d6324b3b020ef5c92c608c [diff]
MergeSuperSet: Remove indirect ChangeControl usage

ChangeControl was used in MergeSuperSet using an indirection inside
ChangeData. By calling changeData.changeControl(CurrentUser) ChangeData
would keep an instance of ChangeControl with the given user. This
instance was used inside MergeSuperSet only.

This commit removes this usage by removing the method on ChangeData that
lets callers specify a user for the ChangeControl instance and uses
ChangeControl inside MergeSuperSet only where really needed.

In addition, this commit moves visiblePatchSets from ChangeData to
ChangeControl to enforce callers to provide an explicit ChangeControl
instance to call this method on. However, this method is only needed
temporarily until drafts are deprecated.

Change-Id: I7f760f5d915bd268fe2f49120022114f3e246e45
4 files changed
tree: c810e687f37c2827983b955f98b828da9273a21e
  1. .settings/
  2. contrib/
  3. Documentation/
  4. gerrit-acceptance-framework/
  5. gerrit-acceptance-tests/
  6. gerrit-cache-h2/
  7. gerrit-common/
  8. gerrit-elasticsearch/
  9. gerrit-extension-api/
  10. gerrit-gpg/
  11. gerrit-gwtdebug/
  12. gerrit-gwtexpui/
  13. gerrit-gwtui/
  14. gerrit-gwtui-common/
  15. gerrit-httpd/
  16. gerrit-index/
  17. gerrit-launcher/
  18. gerrit-lucene/
  19. gerrit-main/
  20. gerrit-oauth/
  21. gerrit-openid/
  22. gerrit-patch-commonsnet/
  23. gerrit-patch-jgit/
  24. gerrit-pgm/
  25. gerrit-plugin-api/
  26. gerrit-plugin-gwtui/
  27. gerrit-prettify/
  28. gerrit-reviewdb/
  29. gerrit-server/
  30. gerrit-sshd/
  31. gerrit-test-util/
  32. gerrit-util-cli/
  33. gerrit-util-http/
  34. gerrit-util-ssl/
  35. gerrit-war/
  36. lib/
  37. plugins/
  38. polygerrit-ui/
  39. ReleaseNotes/
  40. tools/
  41. website/
  42. .bazelproject
  43. .editorconfig
  44. .git-blame-ignore-revs
  45. .gitignore
  46. .gitmodules
  47. .mailmap
  48. .pydevproject
  49. BUILD
  50. COPYING
  51. fake_pom.xml
  52. INSTALL
  53. README.md
  54. SUBMITTING_PATCHES
  55. version.bzl
  56. WORKSPACE
README.md

Gerrit Code Review

Gerrit is a code review and project management tool for Git based projects.

Build Status

Objective

Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.

Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.

Documentation

For information about how to install and use Gerrit, refer to the documentation.

Source

Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.

Reporting bugs

Please report bugs on the issue tracker.

Contribute

Gerrit is the work of hundreds of contributors. We appreciate your help!

Please read the contribution guidelines.

Note that we do not accept Pull Requests via the Github mirror.

Getting in contact

The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.

The Developer Mailing list is repo-discuss on Google Groups.

License

Gerrit is provided under the Apache License 2.0.

Build

Install Bazel and run the following:

    git clone --recursive https://gerrit.googlesource.com/gerrit
    cd gerrit && bazel build release

Install binary packages (Deb/Rpm)

The instruction how to configure GerritForge/BinTray repositories is here

On Debian/Ubuntu run:

    apt-get update & apt-get install gerrit=<version>-<release>

NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.

On CentOS/RedHat run:

    yum clean all && yum install gerrit-<version>[-<release>]

On Fedora run:

    dnf clean all && dnf install gerrit-<version>[-<release>]

Use pre-built Gerrit images on Docker

Docker images of Gerrit are available on DockerHub

To run a CentOS 7 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]

To run a Ubuntu 15.04 based Gerrit image:

    docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]

NOTE: release is optional. Last released package of the version is installed if the release number is omitted.