commit | 81487a526905b646cfd5524acca572d4376efec1 | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Thu Dec 05 13:35:04 2019 +0100 |
committer | Edwin Kempin <ekempin@google.com> | Thu Dec 05 17:11:29 2019 +0100 |
tree | 15cc78e9d573d2b99f082c3a367698057692fccb | |
parent | 2342590d94f432b5fee3d4428ade6a386f725d3b [diff] |
ExceptionHook: Add method that allows to control the status code of the response If during the execution of a REST request an exception occurs we return a 500 Internal Server Error response to the user, unless the exception is sepcifically caught and handled in RestApiServlet. Now, with the new method implementors of the ExceptionHook extension point can control the REST response for arbitrary exceptions. The new getStatusCode method allows them to decide on the HTTP status code and the already existing getUserMessage method allows them to define the message in the response body. This is useful if environment-specific exceptions should be handled. E.g. at Google we have a specific exception that is thrown if a client disconnects. At the moment this exception results in an internal server error, which affects our SLO metrics. A disconnected client is not an error and we would rather return 200 OK in this case. Signed-off-by: Edwin Kempin <ekempin@google.com> Change-Id: I04b1e2cfc002289ca8b405ce11449d3c445165c5
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.