| commit | 80d1c3b6c8ea6caed47377d5bae837494c947ecb | [log] [tgz] |
|---|---|---|
| author | Logan Hanks <logan@google.com> | Thu May 11 15:26:58 2017 -0700 |
| committer | Logan Hanks <logan@google.com> | Thu May 11 22:42:38 2017 +0000 |
| tree | c5b042a6f6ecd1f11c9cc3d2d4866b392b99af82 | |
| parent | ad62ecbabfc93d8173e7df4d0e37fccb824ab4c0 [diff] |
Fix NPE when default field expansions are omitted A recent change[1] fixes "too many terms" errors when default fields are used on sites with many accounts. Its approach was to replace overly large OR predicates with the ANY predicate. It turns out that AND and OR predicates do not support ANY as a child. To fix this, we'll omit adding any predicate at all to the tree when the predicate is elided. This involves checking for and accommodating ANY in a few different places so we can avoid adding a predicate to the list produced in the defaultField method. [1] Ibf6960976122e8170954ec20d3df9b50f597c5f7 Change-Id: If727aeabbc0de3d50febbf329ecfd32971f6c216
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.