commit | 809e8e108bc09a2d8b84bd9e30733341b74f95a4 | [log] [tgz] |
---|---|---|
author | Patrick Hiesel <hiesel@google.com> | Mon Mar 04 16:00:42 2019 +0100 |
committer | Patrick Hiesel <hiesel@google.com> | Tue Mar 05 17:45:20 2019 +0100 |
tree | 145ab4006689c534eb7f05afb21771677e9d445c | |
parent | 3341999a0042104fe9921b393441d5af3fa42e50 [diff] |
Fix child collection bindings in RestApiServlet and add tests The Gerrit Plugin injector and the RestApiServlet currently have different bugs. This commit papers over the most pressing ones and adds tests so that plugins can bind child collections and offer modifications directly on the collections (e.g. postOnCollection). When binding rest views from plugins, the plugin name is incorrectly set to "gerrit" which is what we use for core Gerrit views. This does not apply to collections though. These are bound with the correct plugin name "plugin-name". In RestApiServlet, this leads to a situation where the collection thinks it belongs to a different part of Gerrit. For operations that modify the collection (post, delete) this means we have to use "gerrit" as the component name when looking up child views. For root collections, we already do this and this is why it works for existing plugin root collections. For subcollections, however, we did not - which is what this commit changes. Now the two usages in RestApiServlet are consistent. To be clear: They are now consistently wrong across the different parts of Gerrit, but they are consistent which means they work. As future work, we want to fix this long standing issue by binding the correct plugin names from the beginning. This is non-trivial though because the DynamicMapProvider has no context on the plugin that is performing the binding. This commit adds the same logic that we have for core-collection delegation to plugin-collections in RestApiServlet. Change-Id: I954105155c4a354b6c577d8cc246d00998e33f57
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.