Remove `toggleClass()` utility function
`classList.toggle()` does exactly the same thing and is an officially
supported DOM method.
Release-Notes: skip
Change-Id: Id90965cf1ed14c05a5f98da181088524a693e8c5
diff --git a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts
index fdacf8b..5533add 100644
--- a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts
+++ b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts
@@ -28,7 +28,7 @@
ScrollMode,
SpecialFilePath,
} from '../../../constants/constants';
-import {descendedFromClass, Key, toggleClass} from '../../../utils/dom-util';
+import {descendedFromClass, Key} from '../../../utils/dom-util';
import {
computeDisplayPath,
computeTruncatedPath,
@@ -666,7 +666,7 @@
);
this.shortcutsController.addAbstract(
Shortcut.TOGGLE_HIDE_ALL_COMMENT_THREADS,
- _ => toggleClass(this, 'hideComments')
+ _ => this.classList.toggle('hideComments')
);
this.shortcutsController.addAbstract(
Shortcut.CURSOR_NEXT_FILE,
diff --git a/polygerrit-ui/app/elements/checks/gr-checks-results.ts b/polygerrit-ui/app/elements/checks/gr-checks-results.ts
index 8e2aa6e..b8bfec5 100644
--- a/polygerrit-ui/app/elements/checks/gr-checks-results.ts
+++ b/polygerrit-ui/app/elements/checks/gr-checks-results.ts
@@ -50,7 +50,7 @@
computeIsExpandable,
} from '../../models/checks/checks-util';
import {assertIsDefined, assert, unique} from '../../utils/common-util';
-import {modifierPressed, toggleClass, whenVisible} from '../../utils/dom-util';
+import {modifierPressed, whenVisible} from '../../utils/dom-util';
import {durationString} from '../../utils/date-util';
import {charsOnly} from '../../utils/string-util';
import {isAttemptSelected, matches} from './gr-checks-util';
@@ -558,7 +558,7 @@
horizontal-align="right"
@tap-item=${this.handleAction}
@opened-changed=${(e: ValueChangedEvent<boolean>) =>
- toggleClass(this, 'dropdown-open', e.detail.value)}
+ this.classList.toggle('dropdown-open', e.detail.value)}
?hidden=${overflowItems.length === 0}
.items=${overflowItems}
.disabledIds=${disabledItems}
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
index 246e7ed..acb1ef3 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
+++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.ts
@@ -62,7 +62,7 @@
import {OpenFixPreviewEvent, ValueChangedEvent} from '../../../types/events';
import {fireAlert, fire} from '../../../utils/event-util';
import {assertIsDefined, queryAndAssert} from '../../../utils/common-util';
-import {toggleClass, whenVisible} from '../../../utils/dom-util';
+import {whenVisible} from '../../../utils/dom-util';
import {CursorMoveResult} from '../../../api/core';
import {throttleWrap} from '../../../utils/async-util';
import {filter, take, switchMap, map} from 'rxjs/operators';
@@ -1751,7 +1751,7 @@
}
private handleToggleHideAllCommentThreads() {
- toggleClass(this, 'hideComments');
+ this.classList.toggle('hideComments');
}
private handleOpenFileList() {
diff --git a/polygerrit-ui/app/embed/diff/gr-diff-cursor/gr-diff-cursor.ts b/polygerrit-ui/app/embed/diff/gr-diff-cursor/gr-diff-cursor.ts
index ed6e9da..2d1acf8 100644
--- a/polygerrit-ui/app/embed/diff/gr-diff-cursor/gr-diff-cursor.ts
+++ b/polygerrit-ui/app/embed/diff/gr-diff-cursor/gr-diff-cursor.ts
@@ -13,7 +13,6 @@
LineSelectedEventDetail,
} from '../../../api/diff';
import {ScrollMode, Side} from '../../../constants/constants';
-import {toggleClass} from '../../../utils/dom-util';
import {
GrCursorManager,
isTargetable,
@@ -436,8 +435,8 @@
if (!this.diffRowTR) {
return;
}
- toggleClass(this.diffRowTR, LEFT_SIDE_CLASS, this.side === Side.LEFT);
- toggleClass(this.diffRowTR, RIGHT_SIDE_CLASS, this.side === Side.RIGHT);
+ this.diffRowTR.classList.toggle(LEFT_SIDE_CLASS, this.side === Side.LEFT);
+ this.diffRowTR.classList.toggle(RIGHT_SIDE_CLASS, this.side === Side.RIGHT);
}
// visible for testing
diff --git a/polygerrit-ui/app/utils/dom-util.ts b/polygerrit-ui/app/utils/dom-util.ts
index 67c78cd..03728a0 100644
--- a/polygerrit-ui/app/utils/dom-util.ts
+++ b/polygerrit-ui/app/utils/dom-util.ts
@@ -288,20 +288,6 @@
}
/**
- * Toggles a CSS class on or off for an element.
- */
-export function toggleClass(el: Element, className: string, bool?: boolean) {
- if (bool === undefined) {
- bool = !el.classList.contains(className);
- }
- if (bool) {
- el.classList.add(className);
- } else {
- el.classList.remove(className);
- }
-}
-
-/**
* For matching the `key` property of KeyboardEvents. These are known to work
* with Firefox, Safari and Chrome.
*/
