Replace `editLoaded` with `editMode`
Done for clarity and differentiation with `editPatchsetLoaded`.
Bug: Issue 4437
Change-Id: I05432b202921cad7f906a1cbe9ed68aaeac164cb
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.html b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.html
index 0952ebd..5e6edb0 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.html
+++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.html
@@ -116,7 +116,7 @@
display: block;
overflow: auto;
}
- .editLoaded .hideOnEdit {
+ .editMode .hideOnEdit {
display: none;
}
.blameLoader {
@@ -188,7 +188,7 @@
}
</style>
<gr-fixed-panel
- class$="[[_computeContainerClass(_editLoaded)]]"
+ class$="[[_computeContainerClass(_editMode)]]"
floating-disabled="[[_panelFloatingDisabled]]"
keep-on-scroll
ready-for-measure="[[!_loading]]">
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
index 24986ee..a8ada4a 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
+++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
@@ -132,9 +132,9 @@
type: Boolean,
value: () => { return window.PANEL_FLOATING_DISABLED; },
},
- _editLoaded: {
+ _editMode: {
type: Boolean,
- computed: '_computeEditLoaded(_patchRange.*)',
+ computed: '_computeEditMode(_patchRange.*)',
},
_isBlameSupported: {
type: Boolean,
@@ -244,7 +244,7 @@
},
_setReviewed(reviewed) {
- if (this._editLoaded) { return; }
+ if (this._editMode) { return; }
this.$.reviewed.checked = reviewed;
this._saveReviewedState(reviewed).catch(err => {
this.fire('show-alert', {message: ERR_REVIEW_STATUS});
@@ -882,16 +882,16 @@
/**
* @param {!Object} patchRangeRecord
*/
- _computeEditLoaded(patchRangeRecord) {
+ _computeEditMode(patchRangeRecord) {
const patchRange = patchRangeRecord.base || {};
return this.patchNumEquals(patchRange.patchNum, this.EDIT_NAME);
},
/**
- * @param {boolean} editLoaded
+ * @param {boolean} editMode
*/
- _computeContainerClass(editLoaded) {
- return editLoaded ? 'editLoaded' : '';
+ _computeContainerClass(editMode) {
+ return editMode ? 'editMode' : '';
},
_computeBlameToggleLabel(loaded, loading) {
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view_test.html b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view_test.html
index 8e79a9b..4daabe3 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view_test.html
+++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view_test.html
@@ -551,7 +551,7 @@
element._patchRange = {patchNum: element.EDIT_NAME};
flushAsynchronousOperations();
- assert.isTrue(element._editLoaded);
+ assert.isTrue(element._editMode);
element._setReviewed();
assert.isFalse(saveReviewedStub.called);
});
@@ -868,15 +868,15 @@
});
});
- test('_computeEditLoaded', () => {
- const callCompute = range => element._computeEditLoaded({base: range});
+ test('_computeEditMode', () => {
+ const callCompute = range => element._computeEditMode({base: range});
assert.isFalse(callCompute({}));
assert.isFalse(callCompute({basePatchNum: 'PARENT', patchNum: 1}));
assert.isFalse(callCompute({basePatchNum: 'edit', patchNum: 1}));
assert.isTrue(callCompute({basePatchNum: 1, patchNum: 'edit'}));
});
- suite('editLoaded behavior', () => {
+ suite('editMode behavior', () => {
setup(() => {
element._loggedIn = true;
});
