commit 8016604777f5c114698ca4766b01eab64b0565a9
author Ben Rohlfs <brohlfs@google.com> Tue Feb 15 18:20:17 2022 +0100
committer Ben Rohlfs <brohlfs@google.com> Thu Feb 24 21:33:53 2022 +0100
tree 6ad1d98399cd47aa159ee9e8b9f059748a20dd3b
parent 3f2001bf66677b9043da574cd42aeede92f52b8f

Remove a TODO about checking `comment-side` in thread elements

All users of gr-diff are using `diff-side` attribute.

Release-Notes: skip
Change-Id: I4d836ebba6eebfb45a2b20ebb874f8743968951b

polygerrit-ui/app/embed/diff/gr-diff/gr-diff-utils.ts

diff --git a/polygerrit-ui/app/embed/diff/gr-diff/gr-diff-utils.ts b/polygerrit-ui/app/embed/diff/gr-diff/gr-diff-utils.ts
index 94a7a84..182d48e 100644
--- a/polygerrit-ui/app/embed/diff/gr-diff/gr-diff-utils.ts
+++ b/polygerrit-ui/app/embed/diff/gr-diff/gr-diff-utils.ts
@@ -146,10 +146,7 @@
 }
 
 export function getSide(threadEl: HTMLElement): Side | undefined {
-  // TODO(dhruvsri): Remove check for comment-side once all users of gr-diff
-  // start setting diff-side
-  const sideAtt =
-    threadEl.getAttribute('diff-side') || threadEl.getAttribute('comment-side');
+  const sideAtt = threadEl.getAttribute('diff-side');
   if (!sideAtt) {
     console.warn('comment thread without side');
     return undefined;